This should work - once vivek comes back let's discuss.#6
This should work - once vivek comes back let's discuss.#6
Conversation
nmondal
requested review from
ManojSarwa,
Murtaza-arif,
mrunallohia05,
sarkar-arup,
sarthak-baiswar and
vivek-commits
| Response cachedResponse = new Response.Builder() | ||
| .request(original) | ||
| .protocol(Protocol.HTTP_1_1) | ||
| .code(201) |
There was a problem hiding this comment.
Copied from original code : CREATED 201
:-)
| .message("") | ||
| .body(ResponseBody.create(responseJSON, okhttp3.MediaType.parse(MEDIA_TYPE_JSON))) | ||
| .build(); | ||
| if ( HEAD_PEEK ){ |
There was a problem hiding this comment.
We could do this without compromising on the time taken to load the response. Since we use observables in android, we could sent the cached response as is and at the same time send a parallel request in a co-routine to check the validity of this response (using the head message like below). This way the UI will load faster and at the same time, load the changed response (if server has updated response).
There was a problem hiding this comment.
@Murtaza-arif , @sarthak-baiswar - who wants to take this up? @nmondal has created a partial poc with this pull request.
There was a problem hiding this comment.
But for every GET api, we need to create a HEAD API as well?
There was a problem hiding this comment.
This is just the idea. We have to see if apiv3 supports adding custom headers, if not it will be handled as an additional attribute in sirius response. The idea is correct - the implementation is left to you guys on what integrates better with compass.
3 participants
https://compass-tech.atlassian.net/browse/AAAA-2514