Open
Conversation
Member
hiddn
commented
Mar 29, 2026
hiddn
commented
- Implement LPC trie in ircu using the fast_cidr_lookups library from https://github.com/hiddn/fast_cidr_lookups
- Restore gliter() to original 3-parameter form (list, gl, next). The tree/node params were unnecessary: the CIDR node cleanup code was ineffective since cidr_rem_node() refuses to remove nodes with data==NULL (treats them as virtual nodes). - Simplify gliterIpMask(): skip iteration if tree is NULL instead of allocating an empty tree on every lookup. - Simplify gliterExactIpMask(): compact NULL-safe form. - Remove dead code: unused cidr variable in gline_find(). - Fix comment style: use /* */ instead of // for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.