fix(tests): stabilize test_ignored_keywords across CI#647
Open
Bingtagui404 wants to merge 1 commit intoUltraplot:mainfrom
Open
fix(tests): stabilize test_ignored_keywords across CI#647Bingtagui404 wants to merge 1 commit intoUltraplot:mainfrom
Bingtagui404 wants to merge 1 commit intoUltraplot:mainfrom
Conversation
Remove the skip marker and replace brittle warning-count assertions with specific message-content checks. Filter only UltraPlotWarning instances and verify the expected keyword names appear in the warning messages, making the test resilient to unrelated warnings from different environments. closes Ultraplot#641
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@pytest.mark.skipfromtest_ignored_keywordslen(record) == 3count assertions with specific message-content checksUltraPlotWarningcategory usingissubclassinstead of string matchingwarnings.simplefilter("always")to ensure warnings are captured regardless of environmentcloses #641