Fix duplicate shared boxplot tick labels#630
Merged
cvanelteren merged 5 commits intomainfrom Mar 19, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a regression in UltraPlot’s boxplot wrapper where repeated boxplot() calls on axes with stronger x-axis sharing (sharex >= 2) could accumulate duplicate fixed tick labels, causing duplicated/bold x tick label rendering. Adds a regression test for the reported scenario (issue #628).
Changes:
- Add shared-axis detection for boxplot tick management and bypass Matplotlib’s appending tick-manager on shared tickers.
- Install fixed tick locator/formatter once per call for shared axes to prevent duplicated tick labels.
- Add a regression test ensuring shared x axes do not end up with duplicated tick label text.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
ultraplot/axes/plot.py |
Avoid Matplotlib’s tick-manager path on shared tick axes and apply fixed ticks/labels without duplication. |
ultraplot/tests/test_plot.py |
Adds regression test covering repeated boxplot calls under sharex=2 to ensure tick labels don’t duplicate. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
Manual inspection looks good. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the shared-axis boxplot regression where repeated
boxplotcalls on axes withsharex >= 2could append the same fixed tick labels multiple times, making the x tick labels appear duplicated or bold. The boxplot wrapper now avoids Matplotlib's appending tick manager on already shared axes and applies the intended tick labels once, with a regression test covering the reported case. Closes #628.