Conversation
- Add assertion tests for matmul of impure tensors Signed-off-by: Gausshj <kylin_0@qq.com>
- Add trace support for tensor - Add simply test for trace Signed-off-by: Gausshj <kylin_0@qq.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This reverts commit 156b5d0.
hzhangxyz
reviewed
Sep 16, 2025
grassmann_tensor/tensor.py
Outdated
| if edge_first != edge_end: | ||
| raise ValueError(f"Incompatible edges: {edge_first} and {edge_end}.") | ||
|
|
||
| if tensor.arrow[trace_pair[0]] != tensor.arrow[trace_pair[1]]: |
hzhangxyz
reviewed
Sep 16, 2025
| order_first = order.pop(trace_pair[0]) | ||
| order_end = order.pop(trace_pair[1]) | ||
| order[trace_pair[0] : trace_pair[0]] = [order_first, order_end] | ||
| tensor = tensor.permute(tuple(order)) |
Member
There was a problem hiding this comment.
不然你对符号的处理完全不对，最后两个指标trace的时候，T F的话，不需要加任何符号，F T的话，需要根据最后两个指标的parity加符号（2个相互trace的指标的parity应该是完全一致的）。
Collaborator
Author
There was a problem hiding this comment.
那能否通过permute来实现，将需要trace的指标移到最后，然后再按照当前的代码逻辑来求trace？
Member
There was a problem hiding this comment.
那能否通过permute来实现，将需要trace的指标移到最后，然后再按照当前的代码逻辑来求trace？
是的，确实是应该这么干的，先实现下最后两个指标的，然后外面套个permute。
Member
There was a problem hiding this comment.
只要你能把两个指标的trace写对，后面套permute很难写错，所以建议你先把两个指标的版本写对。
Member
There was a problem hiding this comment.
然后再按照当前的代码逻辑来求trace
你现在的符号没处理对啊
Member
There was a problem hiding this comment.
不是没处理对符号，是没处理符号=_=、、、你只需要permute成T F的话，符号才可以恰好不用处理。
- Remove unnecessary judge for arrow Signed-off-by: Gausshj <kylin_0@qq.com>
This was referenced Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for trace