Add examples from KELE.

[hzhangxyz]

No description provided.

[Copilot]

Pull request overview

This pull request adds example files from KELE to demonstrate the DDSS (Distributed Deductive System Sorts) capabilities. The PR includes runner scripts in both TypeScript and Python, along with multiple domain-specific language (DSP) example files covering relationship reasoning, arithmetic operations, and complex geometry problems.

Changes:

• Added example runner scripts (main.ts and main.py) that load DSP files and execute deductive reasoning
• Added 14 DSP example files demonstrating various reasoning tasks (relationships, arithmetic, and geometry)

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
examples/main.ts	TypeScript runner that loads DSP files, executes reasoning engines, and handles arithmetic operations
examples/main.py	Python runner with equivalent functionality to the TypeScript version
examples/relationship_quick_start.dsp	Simple family relationship example demonstrating grandparent inference
examples/relationship.dsp	Extended family relationship example with uncle/sibling rules
examples/arithmetic_example.dsp	Arithmetic reasoning example demonstrating sum operations
examples/geometry_for_wo_tool_complex_1.dsp	Complex geometry reasoning problem (97 lines)
examples/geometry_for_wo_tool_complex_2.dsp	Complex geometry reasoning problem (45 lines)
examples/geometry_for_wo_tool_complex_3.dsp	Complex geometry reasoning problem (78 lines)
examples/geometry_for_wo_tool_complex_4.dsp	Complex geometry reasoning problem (37 lines)
examples/geometry_for_wo_tool_complex_5.dsp	Complex geometry reasoning problem (30 lines)
examples/geometry_for_wo_tool_complex_6.dsp	Complex geometry reasoning problem (35 lines)
examples/geometry_for_wo_tool_complex_7.dsp	Complex geometry reasoning problem (35 lines)
examples/geometry_for_wo_tool_complex_8.dsp	Complex geometry reasoning problem (29 lines)
examples/geometry_for_wo_tool_complex_9.dsp	Complex geometry reasoning problem (86 lines)
examples/geometry_for_wo_tool_complex_10.dsp	Complex geometry reasoning problem (68 lines)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The conclusion has a duplicate variable P5 in Cyclic(P2, P3, P5, P5). Based on the premise conditions and comparison with similar rules (R1 at line 31), this should likely be Cyclic(P2, P3, P5, P4) or another appropriate variable representing the fourth point. The duplicate P5 will cause incorrect cyclic inference.

Suggested change

	Length(`P1, `P2) == Length(`P1, `P3), Length(`P1, `P3) == Length(`P1, `P4), Length(`P1, `P5) == Length(`P1, `P4), Length(`P1, `P6) == Length(`P1, `P3) => Cyclic(`P2, `P3, `P5, `P5)
	Length(`P1, `P2) == Length(`P1, `P3), Length(`P1, `P3) == Length(`P1, `P4), Length(`P1, `P5) == Length(`P1, `P4), Length(`P1, `P6) == Length(`P1, `P3) => Cyclic(`P2, `P3, `P4, `P5)

[Copilot]

Missing input validation for command-line arguments. The Python implementation does not check if a file name argument is provided before accessing sys.argv[1], which will raise an IndexError if no argument is given. The TypeScript version at line 230 properly validates this condition and provides a user-friendly error message. Consider adding a check similar to the TypeScript implementation.

[Copilot]

The temporary directory created is not properly managed. The TemporaryDirectory object should be used as a context manager or explicitly cleaned up to ensure the temporary directory is removed after execution. Consider using with tempfile.TemporaryDirectory(prefix="ddss-") as tmpdir: to ensure proper cleanup.

Suggested change

	tmpdir = tempfile.TemporaryDirectory(prefix="ddss-")
	path = pathlib.Path(tmpdir.name) / "ddss.db"
	addr = f"sqlite+aiosqlite:///{path.as_posix()}"
	file_name = sys.argv[1]
	asyncio.run(run(addr, file_name))
	with tempfile.TemporaryDirectory(prefix="ddss-") as tmpdir:
	path = pathlib.Path(tmpdir) / "ddss.db"
	addr = f"sqlite+aiosqlite:///{path.as_posix()}"
	file_name = sys.argv[1]
	asyncio.run(run(addr, file_name))

[Copilot]

File handle is not properly closed. The file should be opened using a context manager (with open(...)) to ensure it is properly closed even if an exception occurs during processing.

Suggested change

	for line in open(file_name, "rt", encoding="utf-8"):
	data = line.strip()
	if data == "":
	continue
	if data.startswith("//"):
	continue
	try:
	ds = parse(data)
	except Exception as e:
	print(f"error: {e}")
	continue
	await insert_or_ignore(sess, Facts, ds)
	if idea := str_rule_get_str_idea(ds):
	await insert_or_ignore(sess, Ideas, idea)
	with open(file_name, "rt", encoding="utf-8") as f:
	for line in f:
	data = line.strip()
	if data == "":
	continue
	if data.startswith("//"):
	continue
	try:
	ds = parse(data)
	except Exception as e:
	print(f"error: {e}")
	continue
	await insert_or_ignore(sess, Facts, ds)
	if idea := str_rule_get_str_idea(ds):
	await insert_or_ignore(sess, Ideas, idea)

[Copilot]

'except' clause does nothing but pass and there is no explanatory comment.

[Copilot]

'except' clause does nothing but pass and there is no explanatory comment.

Suggested change

	except asyncio.CancelledError:
	except asyncio.CancelledError:
	# Intentionally ignore cancellation here so that the engine is always
	# disposed in the finally block below.