Conversation
|
The raw data and the data in Remaining tasks before this PR is ready for review:
|
Co-authored-by: gvegayon <893619+gvegayon@users.noreply.github.com>
|
I don't see any R code yet, is that expected? |
Co-authored-by: gvegayon <893619+gvegayon@users.noreply.github.com>
|
Yes, it's expected. All the code is in the repo epigames-analysis-recreation. I just sent an invitation if you want to have a look now. The repo is very similar to the one from Andres, but this one has the new notebook 1-data-parsing-R-format.ipynb, and the notebook 4-diffusion-analysis.Rmd has been updated to the WKU dataset (165). If you run both, you should get the data you saw in the commit of this PR. I'll be getting back to work soon. |
gvegayon
left a comment
There was a problem hiding this comment.
Hey @aoliveram, looks great! Thanks for doing this. I left a couple of comments.
data-raw/epigamesDiffNet.R
Outdated
| save(epigamesDiffNet, file = "data/epigamesDiffNet.rda", compress = "xz") | ||
|
|
||
| message("diffnet object successfully created and exported to data/epigamesDiffNet.rda") |
There was a problem hiding this comment.
Let's use the usethis::use_data() function instead.
data-raw/epigames.R
Outdated
| ) | ||
|
|
||
| # Save as .rda compressed using xz for CRAN compliance | ||
| save(epigames_raw, file = "data/epigames_raw.rda", compress = "xz") |
There was a problem hiding this comment.
Same thing here, let's use the usethis::use_data() functionality. About the names, let's follow the same convention we are using for the other datasets, this ise, let's name the datasets epigames and epigamesDiffNet.
R/data.r
Outdated
| NULL # "fakeEdgelist" | ||
|
|
||
|
|
||
| #' Epi Games Dataset (Raw version) |
There was a problem hiding this comment.
No need to add the "Raw" label, we aren't doing that with the other datasets.
|
Thanks for the comments @gvegayon. I was working on the |
3d739bc to
f14bcef
Compare
|
Hi @gvegayon! Lots of news. Long history short, now we have a I want you to review the novelties, but especially to address an issue I had with GitHub Actions: the This is a summary made by the IA: |
gvegayon
left a comment
There was a problem hiding this comment.
Looking good, @aoliveram! Yeah, the macos stuff is bugging me across many projects. I don't have a solution yet, so I think is OK for the moment to forget about it. Made some comments.
| Package: netdiffuseR | ||
| Title: Analysis of Diffusion and Contagion Processes on Networks | ||
| Version: 1.24.0 | ||
| Version: 1.24.2 |
There was a problem hiding this comment.
The version should be 1.25.0. The versioning is done using
[major].[minor].[patches]
- Major: Something that breaks the current code
- Minor: New features that don't break the code.
- Path: Internal changes fixing bugs or improving things (invisible for the user).
| * New dataset `epigames` and `epigamesDiffNet`: a simulated epidemic game | ||
| network with 594 nodes and 15 time periods from the WKU Epi Games study. | ||
|
|
||
| * New dataset `wku_diffnet`: a `diffnet` object from the WKU simulation study. |
There was a problem hiding this comment.
Should also be wkuDiffNet to keep consistency. I don't see the code that generates that dataset.
| # Changes in netdiffuseR version 1.24.1 (2026-03-03) | ||
|
|
||
| * Fixed CRAN example error in `round_to_seq()`: `plot(w, x)` replaced with | ||
| `plot(w)` to avoid `%||%` operator issue in R 4.4.0+'s `formula.default` | ||
| when called via `plot.data.frame()`. | ||
|
|
There was a problem hiding this comment.
Let's add to the list of changes in version 1.25.0.
Closes #69
Opening this draft PR to start integrating the Epigames datasets into
netdiffuseR.So far, I've only added the raw data files for the datasets we discussed. I will be pushing the parsing functions and documentation in the upcoming commits.
To-do list:
-[x] Add raw datasets (game 165).
.mtxfiles intoCsparseMatrixanddiffnetobjects.I'll mark this as ready for review once the code and docs are complete!