Refactored Display implementation for Platform enum#2
Open
sebihutanu wants to merge 8 commits intoUPB-CS-OpenSourceUpstream:stablefrom
Open
Refactored Display implementation for Platform enum#2sebihutanu wants to merge 8 commits intoUPB-CS-OpenSourceUpstream:stablefrom
sebihutanu wants to merge 8 commits intoUPB-CS-OpenSourceUpstream:stablefrom
Conversation
|
Please make sure you have here only your files changed. It sees that you changed the line endings. |
alexandruradovici
requested changes
Jan 22, 2024
alexandruradovici
requested changes
Jan 22, 2024
alexandruradovici
left a comment
alexandruradovici
left a comment
There was a problem hiding this comment.
Please modify the title of the pull request.
alexandruradovici
requested changes
Jan 22, 2024
alexandruradovici
left a comment
alexandruradovici
left a comment
There was a problem hiding this comment.
This command line utility might be used in scripts that do not want the graphic display. I suggest two solutions here:
- add a command line flag
- verify if you are running using a terminal (https://crates.io/crates/is-terminal) and display the drawn version or, if you are not running using a terminal - ie in a pipe, display the text version
sebihutanu
changed the title
alexandruradovici
approved these changes
Jan 23, 2024
alexandruradovici
left a comment
alexandruradovici
left a comment
There was a problem hiding this comment.
Looks good, please send this to upstream and place a link to it here. Please explain the idea with the terminal in the pull request description.
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHOAMI
Key Changes:
Display Restructuring:
disp.rs, to centralize and streamline platform-specific display functions.Aesthetic Enhancements:
To enhance the utility's adaptability, a crucial implementation has been added. The program checks whether it is running in a terminal environment (using https://crates.io/crates/is-terminal) before deciding how to display the platform. If executed in a terminal, the graphical version is presented; otherwise, in scenarios like running in a pipe, the text version is displayed.