Input and Output#20
Open
TrifanBogdan24 wants to merge 13 commits intoUPB-CS-OpenSourceUpstream:masterfrom
Open
Input and Output#20TrifanBogdan24 wants to merge 13 commits intoUPB-CS-OpenSourceUpstream:masterfrom
TrifanBogdan24 wants to merge 13 commits intoUPB-CS-OpenSourceUpstream:masterfrom
Conversation
Author
|
All the other chapters are not modified |
Closed
D9nni
reviewed
Jan 8, 2024
D9nni
reviewed
Jan 8, 2024
Author
|
Thank you D9nni for the feedback, I hope it is all right now. |
|
State in the description that you added a chapter to the tutorials. |
alexandruradovici
requested changes
Jan 9, 2024
alexandruradovici
left a comment
alexandruradovici
left a comment
There was a problem hiding this comment.
Please modify the translations for chapter 10 also.
mariapana
suggested changes
Jan 11, 2024
andreigheta
suggested changes
Jan 12, 2024
TrifanBogdan24
force-pushed
the
new-chapter
branch
from
a9a2d17 to
73e36d7
Compare
|
@TrifanBogdan24 please mark the changes that you made as resolved. |
alexandruradovici
approved these changes
Jan 19, 2024
mariapana
approved these changes
Jan 19, 2024
andreigheta
approved these changes
Jan 20, 2024
alexandruradovici
requested changes
Jan 21, 2024
alexandruradovici
left a comment
alexandruradovici
left a comment
There was a problem hiding this comment.
Please rename all the chapter_10.yaml files to chapter_11.yaml as all the translations have to shift.
D9nni
approved these changes
Jan 22, 2024
alexandruradovici
requested changes
Jan 23, 2024
alexandruradovici
left a comment
alexandruradovici
left a comment
There was a problem hiding this comment.
Please rebase this so you can send it to upstream.
Author
|
I hope that my branch |
Author
|
Here is the link to the upstream: richardanaya#516 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussed topics
Solved issue:
The new explanations are described both in English and Romanian.