Additional explanation to the already existing chapters#19
Additional explanation to the already existing chapters#19TrifanBogdan24 wants to merge 12 commits intoUPB-CS-OpenSourceUpstream:masterfrom
Conversation
|
Thank you Alexe1289 for the feedback, I hope it is all right now. |
alexandruradovici
left a comment
There was a problem hiding this comment.
Looks good, can you add the changes to the Romanian translation also?
|
Sure. I will translate as soon as possible the new explanations. |
|
@TrifanBogdan24 please mark the changes that are fixed as resolved. |
alexandruradovici
left a comment
There was a problem hiding this comment.
Please format the code in Rust Playground.
mariapana
left a comment
There was a problem hiding this comment.
The typos, confusing explanations and other similar issues I pointed out a while ago still exist.
|
Both the English and the Romanian versions have typos, missing words or situations where the subject of the phrase is in plural form while the verb is in singular form etc. Besides these issues, I also made a few suggestions regarding the clarity of the explanations (which are not mandatory, but could be helpful for inexperienced learners). You can refer to my older comments for concrete examples. |
|
Please rebase. |
076e6cd to
c683ce3
Compare
|
@mariapana, I tried correcting the typos. |
|
Looks good! |
f24351e to
0062e4b
Compare
|
I hope that my branch, |
|
Please send this to upstream and place a link here. |
|
Sure, here is the link to the upstream: richardanaya#514 |
Here are some changes I made and my approach of Tour of Rust:
The new explanations are described both in English and Romanian.