translated chapter 8 in romanian#17
Open
aniakchak09 wants to merge 12 commits intoUPB-CS-OpenSourceUpstream:masterfrom
Open
translated chapter 8 in romanian#17aniakchak09 wants to merge 12 commits intoUPB-CS-OpenSourceUpstream:masterfrom
aniakchak09 wants to merge 12 commits intoUPB-CS-OpenSourceUpstream:masterfrom
Conversation
alexandruradovici
requested changes
Jan 7, 2024
alexandruradovici
left a comment
alexandruradovici
left a comment
There was a problem hiding this comment.
Delete the .idea folder from the repository.
IonutBoraciu
reviewed
Jan 7, 2024
IonutBoraciu
reviewed
Jan 7, 2024
IonutBoraciu
reviewed
Jan 7, 2024
mtimaN
reviewed
Jan 7, 2024
IonutBoraciu
reviewed
Jan 7, 2024
IonutBoraciu
reviewed
Jan 7, 2024
iulianalexa
suggested changes
Jan 7, 2024
tudor-cretu
suggested changes
Jan 8, 2024
Co-authored-by: Mihnea Tudor Crețu <59806467+tudor-cretu@users.noreply.github.com>
Co-authored-by: Mihnea Tudor Crețu <59806467+tudor-cretu@users.noreply.github.com>
Co-authored-by: Mihnea Tudor Crețu <59806467+tudor-cretu@users.noreply.github.com>
Co-authored-by: Mihnea Tudor Crețu <59806467+tudor-cretu@users.noreply.github.com>
mariapana
suggested changes
Jan 11, 2024
aniakchak09
requested review from
IonutBoraciu,
alexandruradovici,
iulianalexa,
mariapana,
mtimaN and
tudor-cretu
mariapana
reviewed
Jan 14, 2024
mariapana
left a comment
mariapana
left a comment
There was a problem hiding this comment.
The translation looks good! Just remember to also handle the issue mentioned by @iulianalexa (https://github.com/UPB-CS-OpenSourceUpstream/tour_of_rust/pull/17/files#r1444053647).
|
All those of you that commented here, please approve or disapprove the request. |
iulianalexa
approved these changes
Jan 19, 2024
IonutBoraciu
approved these changes
Jan 19, 2024
mariapana
approved these changes
Jan 19, 2024
mtimaN
approved these changes
Jan 19, 2024
Github-Vektor
approved these changes
Jan 20, 2024
|
Please send this to upstream and place a link to it here. |
alexandruradovici
approved these changes
Jan 21, 2024
Author
|
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.