Open
Conversation
includes GENUNITS table in defaults.py
include GENUNITS table in processing_info_maps.py
prakaa
approved these changes
Dec 8, 2022
Contributor
There was a problem hiding this comment.
Signing off but some things to consider:
- The filter function used by this table is untested (though relatively simple). We will need to add tests:
Closed
Author
|
For those interested... this functionality for GENUNITS + DUALLOC is used in and also available via the package NEMED. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request/update to include GENUNITS table from mms, in particular to allow users to access 'CO2E_EMISSIONS_FACTOR' for a specified date range.
Suggested commits are setup to remove duplicated rows on primary keys: ['GENSETID', 'LASTCHANGED','CO2E_EMISSIONS_FACTOR']. This way the user can also clearly see different assumptions for CO2 factors updated overtime from NTNDP/ISP in 'CO2E_DATA_SOURCE' col