Open
Conversation
…in impact studies The albedo sweep in tutorial 04 previously abused the grid index as a scenario ID via pd.concat, which doesn't generalise to multi-site setups. Replace with a loop that modifies site config directly — the same pattern already used in Part 2 for forcing modifications. This makes the tutorial work identically for single-site and multi-site (e.g. gridded) YAML configurations. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
CI Build PlanChanged FilesDocumentation (1 file)
Build ConfigurationNo code build required -- changes are docs/site/non-code only. Rationale
Updated by CI on each push. See path-filters.yml for category definitions. |
Preview Deployed
Note This preview is ephemeral. It will be lost when:
To restore, push any commit to this PR. |
Review fixes for tutorial_04_impact_studies: - Replace sim._config with sim.config (public property) throughout - Remove unused sim_test cell (dead code never referenced downstream) - Update api-approach.md and conventions.md to recognise config-level as the prescribed pattern for impact study tutorials - Replace em dashes with ASCII -- per project conventions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pd.concatDataFrame-hacking pattern in tutorial 04 (Impact Studies) with direct config-level modificationMotivation
The previous tutorial abused the grid index as a scenario ID, which confused users with real multi-grid setups (see community discussion). The config-level approach works identically for single-site and multi-site configurations.
Test plan
🤖 Generated with Claude Code