Skip to content

HOFF-2043: Nunjucks Refactoring (Details summary partial)#616

Merged
Rhodine-orleans-lindsay merged 1 commit intoHOFF-2024-nunjucks-refactoring-mainfrom
HOFF-2043-nunjucks-details
Apr 1, 2026
Merged

HOFF-2043: Nunjucks Refactoring (Details summary partial)#616
Rhodine-orleans-lindsay merged 1 commit intoHOFF-2024-nunjucks-refactoring-mainfrom
HOFF-2043-nunjucks-details

Conversation

@Rhodine-orleans-lindsay
Copy link
Copy Markdown
Contributor

@Rhodine-orleans-lindsay Rhodine-orleans-lindsay commented Apr 1, 2026

What?

HOFF-2043 - Nunjucks Refactoring (Details summary partial)

Why?

Part of nunjucks refactoring work

How?

  • create detailsComponent macro that reads ${route}.details.summary and ${route}.details.text from pages.json but can also be customised by passing additional arguments for custom summary and text
  • update readme with documentation on details component usage

Testing?

Tested locally on LAMP and in hof/sandbox

Screenshots (optional)

Anything Else? (optional)

Check list

  • I have reviewed my own pull request for linting issues (e.g. adding new lines)
  • I have written tests (if relevant)
  • I have created a JIRA number for my branch
  • I have created a JIRA number for my commit
  • I have followed the chris beams method for my commit https://cbea.ms/git-commit/
    here is an example commit
  • Ensure workflow jobs are passing especially tests
  • I will squash the commits before merging

- create detailsComponent macro that reads ${route}.details.summary and ${route}.details.text from pages.json but can also be customised by passing additional arguments for custom summary and text
- update readme with documentation on details component usage
@Rhodine-orleans-lindsay Rhodine-orleans-lindsay marked this pull request as ready for review April 1, 2026 15:16
Copy link
Copy Markdown

@gregwolversonHO gregwolversonHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Rhodine-orleans-lindsay Rhodine-orleans-lindsay merged commit e3bbd6a into HOFF-2024-nunjucks-refactoring-main Apr 1, 2026
4 of 10 checks passed
@Rhodine-orleans-lindsay Rhodine-orleans-lindsay deleted the HOFF-2043-nunjucks-details branch April 1, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants