Open
Conversation
PaolaDMadd-Pro
force-pushed
the
hoff-2010
branch
2 times, most recently
from
9b5b7db to
c946c35
Compare
PaolaDMadd-Pro
requested review from
Rhodine-orleans-lindsay and
gregwolversonHO
Rhodine-orleans-lindsay
requested changes
Mar 23, 2026
Contributor
Rhodine-orleans-lindsay
left a comment
Rhodine-orleans-lindsay
left a comment
There was a problem hiding this comment.
@PaolaDMadd-Pro I've left some comments and there all also seems to be some failing tests due to syntax issues.
PaolaDMadd-Pro
force-pushed
the
hoff-2010
branch
2 times, most recently
from
d48e075 to
ec31040
Compare
Rhodine-orleans-lindsay
requested changes
Mar 25, 2026
Contributor
Rhodine-orleans-lindsay
left a comment
Rhodine-orleans-lindsay
left a comment
There was a problem hiding this comment.
just a few minor changes suggested
PaolaDMadd-Pro
force-pushed
the
hoff-2010
branch
from
ec31040 to
f57c74e
Compare
Rhodine-orleans-lindsay
approved these changes
Mar 25, 2026
Contributor
Rhodine-orleans-lindsay
left a comment
Rhodine-orleans-lindsay
left a comment
There was a problem hiding this comment.
good work @PaolaDMadd-Pro - fyi, there is a small typo in the changelog, that I have highlighted in a comment.
- update session-timeout-dialog.js : reinforced code of refreshing session, more robust on failure. - update index.js to make connectSrc default to same-origin, then append GA endpoints only when GA is enabled. - update sessionDialog.test.js and server.spec.js to cover new changes - update changelog and readme
PaolaDMadd-Pro
force-pushed
the
hoff-2010
branch
from
f57c74e to
c410d98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Session not extending when “Stay on this page” clicked (regression in v22.10.1 – GA_TAG dependency)
Why?
as per jira ticket HOFF-2010
How?
Testing?
tested on sandbox and Lamp (locally)
Here’s a short PR-ready summary you can paste:
Added tests:
Added frontend Jest coverage for refreshSession in
sessionDialog.test.jsNew success-path test verifies
$.get('')success updates timeSessionRefreshed and callscontroller()New failure-path test verifies
$.get('')failure logsconsole.errorAdded/updated CSP integration coverage in
server.spec.jsto confirm behaviour whengaTagIdis unset:connect-src includes 'self'.
Google analytics domains are not added to img-src/script-src (and can also be asserted absent from connect-src).
Kept existing positive CSP test for
gaTagIdset to assert Google directives are included.Screenshots (optional)
Anything Else? (optional)
Check list
here is an example commit