Feature/add hods theme#412
Feature/add hods theme#412andrewgibson-ibm wants to merge 18 commits intoUKHomeOfficeForms:masterfrom
Conversation
| build/Release | ||
| node_modules | ||
| .emails | ||
| .emails No newline at end of file |
There was a problem hiding this comment.
new line? you can add this in your editor to prevent this happening in the future
| if (e.code !== 'ENOENT') { | ||
| throw e; | ||
| } else { | ||
| console.log(`${chalk.yellow('warning')}: no fonts directory found at ${config.fonts.src}`); |
| .then(() => spawn('cp', ['-r', config.fonts.src, config.fonts.out])) | ||
| .catch(e => { | ||
| if (e.code !== 'ENOENT') { | ||
| throw e; |
There was a problem hiding this comment.
I'm trying to understand this, if you catch an error that doesn't have a specific path/ file directory, you'll throw an error? Would it be better to provide a helpful error message?
| @@ -0,0 +1,14 @@ | |||
| { | |||
| "name": "hmpo-govuk-template-example", | |||
| "description": "Example app for hmpo-govuk-template module", | |||
There was a problem hiding this comment.
Why does it say hmpo?
| </div> | ||
| {{/main}} | ||
|
|
||
| {{/ hods-template}} No newline at end of file |
| /* eslint-disable max-len, no-var, vars-on-top, no-undef */ | ||
| 'use strict'; | ||
|
|
||
| // TODO: update package.json(s) |
There was a problem hiding this comment.
what do you need to update in package.json(s) would it be best to do as this PR?
| }); | ||
| } | ||
| } | ||
| }).call(this); |
There was a problem hiding this comment.
I'm guessing this is just pull it out from hods? if it is, then that's fine if we test it and it works
|
|
||
| .hmpo { | ||
| white-space: nowrap; | ||
| } No newline at end of file |
|
I see that the styles are being copied across rather than having an npm module. I had a look at the HODs site and it looks like that's the way to do it. I sent a message to the team
|
|
|
||
| .hmpo { | ||
| white-space: nowrap; | ||
| } No newline at end of file |
There was a problem hiding this comment.
it's a shame you have to copy the sass and there is no npm module for the sass
| .govuk-back-link:link, | ||
| .govuk-back-link:visited { | ||
| color: #005ea5 !important; | ||
| } No newline at end of file |
| } | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
are all the empty lines on purpose?
|
The email you have sent to ***@***.*** is for a legacy domain and will shortly be removed.
Please update your address book and send to the same address but having removed .gsi. from the domain part.
Mail to legacy addresses will stop working after 31st March 2024
|
|
This is really great work @andrewgibson-ibm there's just some minor linting things to sort out. I also have a question about the sass. Am I right in thinking it has been copied and pasted from the HO design system? If that's the case, then this will make it difficult to maintain in the future. For example if the HO design system updates and changes the sass how can we tell what has changed and how will we update it in the future. I don't know the answer to this so it would be good to discuss. Once we can come to a way forward with this, the next bit would be to publish a beta package of this and test it on multiple services. |
3 participants
Description
Current HOF framework enables the use of
govUKtheme which implements the components and styling designed in the Government Design System. This update enables the use of the Home Office Design System by implementing the relevant styles and page template.Changes
TaskListcomponent has been added{{pageTitle}} - {{appTitle}}Testing
hofpackage in your apphof.settings.json, set"theme": "hods",npm i, thennpm run startto start your app