Skip to content

HOFF-324: create time mixin#384

Open
Rhodine-orleans-lindsay wants to merge 1 commit intomasterfrom
add-time-mixin
Open

HOFF-324: create time mixin#384
Rhodine-orleans-lindsay wants to merge 1 commit intomasterfrom
add-time-mixin

Conversation

@Rhodine-orleans-lindsay
Copy link
Copy Markdown
Contributor

@Rhodine-orleans-lindsay Rhodine-orleans-lindsay commented Feb 16, 2023

What

  • Add time mixin that can be used across services - HOFF-324

Why

  • This was required by a new service but would be more useful in the hof framework so it can be used by any other services that require it.

How

  • Create time component
  • Create time input view
  • Configure template mixin
  • Add relevant validators
  • Add relevant styling
  • Add sandbox example
  • Add relevant tests

Testing

  • Manual tessting
  • Automated tests passing locally

Screenshots (optional)

Anything Else? (optional)

Check list

  • I have reviewed my own pull request for linting issues (e.g. adding new lines)
  • I have written tests (if relevant)
  • I have created a JIRA number for my branch - this PR was created before we started adding jira numbers in the branch name. Since there is already an ongoing review, on this occasion I will keep the branch name as is to avoid losing the review comments.
  • I have created a JIRA number for my commit
  • I have followed the chris beams method for my commit https://cbea.ms/git-commit/
    here is an example commit
  • Ensure workflow jobs are passing especially tests
  • I will squash the commits before merging

Copy link
Copy Markdown
Contributor

@sulthan-ahmed sulthan-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As your changing existing functions like the controller, you'll need to test this against a bunch of complex services like NRM, UKVI-complaints, end-tenancy. I would publish a hof beta package

From previous slack message
Please when you publish a beta package, be very careful. I noticed a beta version was in the public for hof before I published 20.0.0. If you are publishing a beta package, you need to do it like so
npm publish --tag beta
When you publish a beta version it shouldn’t be seen on the npm website. If it is accidentally added then when someone adds hof as a dependency it’ll grab that beta package.
It’s an easy mistake, I recommend publishing a beta package and then checking on the npm website to see you’ve not accidentally added it 🙂

- created time component
- created time input view
- configured template mixin for time component
- added relevant validators
- added relevant styling
- added sandbox example
- added relevant tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants