Conversation
ac473f9 to
ae4e7e2
Compare
sulthan-ahmed
left a comment
There was a problem hiding this comment.
As your changing existing functions like the controller, you'll need to test this against a bunch of complex services like NRM, UKVI-complaints, end-tenancy. I would publish a hof beta package
From previous slack message
Please when you publish a beta package, be very careful. I noticed a beta version was in the public for hof before I published 20.0.0. If you are publishing a beta package, you need to do it like so
npm publish --tag beta
When you publish a beta version it shouldn’t be seen on the npm website. If it is accidentally added then when someone adds hof as a dependency it’ll grab that beta package.
It’s an easy mistake, I recommend publishing a beta package and then checking on the npm website to see you’ve not accidentally added it 🙂
ae4e7e2 to
e23cc60
Compare
- created time component - created time input view - configured template mixin for time component - added relevant validators - added relevant styling - added sandbox example - added relevant tests
e23cc60 to
870e353
Compare
What
Why
How
Testing
Screenshots (optional)
Anything Else? (optional)
Check list
here is an example commit