HOFF-774: Update boilerplate code with DevOps setup#3
Open
adityababumallisettiHO wants to merge 2 commits intoHOF-113-williamfrom
Open
HOFF-774: Update boilerplate code with DevOps setup#3adityababumallisettiHO wants to merge 2 commits intoHOF-113-williamfrom
adityababumallisettiHO wants to merge 2 commits intoHOF-113-williamfrom
Conversation
* Update to the ones used in latest deployments * COA has the latest cron steps and Node Image * ACRS is using private repository ECR * Ingresses have been updated
* This tag can cause issues if git branch has special characters * we use drone commit sha as a tag for all the hof services
|
I'm lost and the hof-boiler-plate should be for our team Let's talk to @william-gu-hof |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
DevOps setup has been changing time to time. We have used new feature on different services. for eg: ACRS uses ECR image repo. COA has the fixed Cron Jobs.
Why?
HOW?
Necessary files have been updated as explained in WHY?
Anything Else?
Our team is not sure of using the Redis secret? Some services using session-secret some use redis secret. But there is no reference of the secret being used .
File vault and Nginx-proxy contaners are using same ports. this could split the incoming traffic between both containers. We have notice it in COA. and Developer deleted the container ports.
I am planning to use Yaml Anchors and alias for few steps in upcoming projects. Once tested. I will add to this repo.
For IMA and ACRS we used internal ingress for dataservice end point. As this is backend service.