Add FontAwesome instructions#30
Conversation
The poster svg files are using FontAwesome. If you don't have that font in your system, some of the graphics will not render correctly. Add a note to the help files about the FontAwesome requirement and some instructions on how to install the font. Signed-off-by: Belen Pena <belenbarrospena@gmail.com>
This commit adds Spanish to the list of translations currently available for the Home Office Digital "Designing for Accessibility" posters. Signed-off-by: Belen Pena <belenbarrospena@gmail.com>
ei8fdb
left a comment
There was a problem hiding this comment.
this information makes sense to add.
|
Hi @belenbarrospena
Then it would be possible to merge the PR. Thank you! |
|
Hi there, Thanks for coming back to me. I think the other Spanish translation PR was sent before mine but not merged, and I didn't realise it was already submitted. My bad: I should have checked the list of PRs before sending mine. I can separate the FontAwesome instructions and create a new PR. Regarding the Spanish translation, I think it's really good, and as the author says it is neutral enough to stay as the only Spanish translation. However, it contains a few ortographical errors and I have some small comments:
This is what I would do:
|
|
Sorry, didn't mean to close, just comment on it :) Reopening |
|
@lopezbreit Hello! Is it possible for you to review the suggestions @belenbarrospena sent above and work together to send a new PR? Appreciate the feedback on this @belenbarrospena :) Thanks. |
|
Sure, @karypun . Hi, @belenbarrospena I´ll be taking a look at your post. |
|
Hi,@belenbarrospena Posters with the reviews: Details: 2. For this one I just added the word ¨breve¨ to make sure we reflect the original meaning. 3. Do you agree on creating a different version for Spain Only for this poster?: |
|
Hi @lopezbreit Sorry for the delay in getting back to you: I was traveling for a while. Thank you so much for the changes: I agree with them all. Regarding 3, I think is too small an issue to grant a different poster. Let's leave it as "video": I honestly can't imagine any Spaniards complaining about this :) Cheers Belén |
|
HI @belenbarrospena, Many thanks for your reply! Best! |
|
@belenbarrospena @lopezbreit I can't merge the PR as there's conflicts that need to be resolved first which is preventing me from merging. Are you able to fix this? Thanks. |
|
Hi, Bolagsverket (the Swedish Companies Registration Office) have translated the posters to swedish how do I upload them so more people from sweden can use them? All the best! :) low-vision_SE.pdf |
|
@TheaLemon I've put your poster translation to issue 57 |
Add Spanish translations, explain the dependency on FontAwesome and explain how to install the font in your system.
Signed-off-by: Belen Pena belenbarrospena@gmail.com