Revert to manual returncode checking for subprocess error handling

[Copilot]

Reverts subprocess error handling in index_collections to match the original maintainer's preferred pattern: manual returncode checking instead of exception-based handling with check=True.

Changes

• Removed check=True from subprocess.run() call
• Restored explicit result.returncode checking with if/else branching
• Kept CalledProcessError exception handler (original defensive coding style)

Code Pattern

Before (exception-based):

result = subprocess.run(cmd, stderr=subprocess.PIPE, check=True)
if result.stderr:
    self.log.error(stderr)
except subprocess.CalledProcessError as e:
    self.log.error(f"Error: {e}")
else:
    self.log.info("Finished indexing...")

After (manual checking):

result = subprocess.run(cmd, stderr=subprocess.PIPE)
if result.stderr:
    self.log.error(stderr)
if result.returncode != 0:
    self.log.error(f"Failed... Return code: {result.returncode}")
else:
    self.log.info("Finished indexing...")
except subprocess.CalledProcessError as e:
    self.log.error(f"Error: {e}")

This matches the coding style familiar to the primary repository maintainer.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.