Define minimum C++ version using ROOT_CXX_STANDARD#1700
Draft
denproc wants to merge 1 commit intoUCL:masterfrom
Draft
Define minimum C++ version using ROOT_CXX_STANDARD#1700denproc wants to merge 1 commit intoUCL:masterfrom
denproc wants to merge 1 commit intoUCL:masterfrom
Conversation
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Adjusted CMake recipe to define minimum C++ version using ROOT_CXX_STANDARD.
Testing performed
The definition of the build variables has been tested on MacOS for
root==6.28,6.30,6.32.However, I could not validate if it builds successfully due to conflict of dependencies between
root,STIR, andlibparallelproj=2(conda installations).Related issues
Fixes #1677
Checklist before requesting a review
documentation/release_XXX.mdhas been updated with any functionality change (if applicable)Contribution Notes
Please tick the following: