Skip to content

Replace deprecated istrstream with istringstream#1698

Merged
KrisThielemans merged 2 commits intoUCL:masterfrom
denproc:fix_istrstream_deprecation
Mar 23, 2026
Merged

Replace deprecated istrstream with istringstream#1698
KrisThielemans merged 2 commits intoUCL:masterfrom
denproc:fix_istrstream_deprecation

Conversation

@denproc
Copy link
Copy Markdown
Contributor

@denproc denproc commented Mar 23, 2026

Changes in this pull request

This pull request addresses the deprecation of std::istrstream described in #1637 by replacing the function with the recommended std::istringstream in KeyParser.cxx and mode.cxx. This update improves compatibility with newer C++ standards and ensures better maintainability.

Testing performed

Tested on MacOS (Apple Silicon) and CUDA-enabled Linux PCs.

Related issues

Fixes #1637

Checklist before requesting a review

  • I have performed a self-review of my code
  • The code builds and runs on my machine
  • documentation/release_XXX.md has been updated with any functionality change (if applicable)

Contribution Notes

Please tick the following:

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in STIR (the Work) under the terms and conditions of the Apache-2.0 License.
  • I (or my institution) have signed the STIR Contribution License Agreement (not required for small changes).

Copy link
Copy Markdown
Collaborator

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. thanks!

@KrisThielemans KrisThielemans added this to the v6.4 milestone Mar 23, 2026
@KrisThielemans KrisThielemans merged commit 2a9b13c into UCL:master Mar 23, 2026
13 checks passed
@denproc denproc deleted the fix_istrstream_deprecation branch March 23, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

std::istrstream is deprecated

2 participants