Replace deprecated istrstream with istringstream#1698
Merged
KrisThielemans merged 2 commits intoUCL:masterfrom Mar 23, 2026
Merged
Replace deprecated istrstream with istringstream#1698KrisThielemans merged 2 commits intoUCL:masterfrom
KrisThielemans merged 2 commits intoUCL:masterfrom
Conversation
KrisThielemans
approved these changes
Mar 23, 2026
Collaborator
KrisThielemans
left a comment
There was a problem hiding this comment.
Perfect. thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
This pull request addresses the deprecation of
std::istrstreamdescribed in #1637 by replacing the function with the recommendedstd::istringstreaminKeyParser.cxxandmode.cxx. This update improves compatibility with newer C++ standards and ensures better maintainability.Testing performed
Tested on MacOS (Apple Silicon) and CUDA-enabled Linux PCs.
Related issues
Fixes #1637
Checklist before requesting a review
documentation/release_XXX.mdhas been updated with any functionality change (if applicable)Contribution Notes
Please tick the following: