Fix sprintf deprecation warnings

[denproc]

Changes in this pull request

Current PR updates deprecated sprintf usage with snprintf and addresses #1586.

Testing performed

Tested on MacOS (Apple Silicon) and CUDA-enabled Linux PCs.

Related issues

Fixes #1586

Checklist before requesting a review

• I have performed a self-review of my code
• The code builds and runs on my machine

Contribution Notes

Please tick the following:

• The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in STIR (the Work) under the terms and conditions of the Apache-2.0 License.
• I (or my institution) have signed the STIR Contribution License Agreement (not required for small changes).

[KrisThielemans]

This is a nice and simple fix. I guess someone will have to check carefully if there's no typo. Or would the compiler flag it up if we use snprintf with the wrong size?

[KrisThielemans]

I went throught this and it's looking good!

I suggest constexpr in a few places, but it doesn't really seem to matter, so let me know if you'd rather not do those. (If you do use github suggestion, please "batch" them up, to avoid too many CI runs).

I will squash-merge this if ok with you.

thanks a lot!

[denproc]

@KrisThielemans, thank you for revieweing the PR and suggesting additional changes!
I have just checked edge cases for snprintf, when buffer length and used size differ:

• For size < length of format string, there will be a warning.
• For size <= length of buffer, there will be no warnings, input data will be truncated to the size.
• For size > length of buffer, there might be buffer overflow depending on input data. No warnings were produces, so it's better to double check the size used in snprintf for new entries.

I'll add your changes and am happy this PR being squash-merged.

[KrisThielemans]

Thanks!