Reduce .toLowerCase() calls by making compiler aware of string cases.#288
Open
Tacodiva wants to merge 3 commits intoTurboWarp:developfrom
Open
Reduce .toLowerCase() calls by making compiler aware of string cases.#288Tacodiva wants to merge 3 commits intoTurboWarp:developfrom
.toLowerCase() calls by making compiler aware of string cases.#288Tacodiva wants to merge 3 commits intoTurboWarp:developfrom
Conversation
|
There are some characters where converting to upper case before comparison is different than converting to lower case, for example the German letter Also, there are some characters that are encoded as a surrogate pair but change when lowercased, which means that joining two strings that are lowercasing-invariant can produce a string that changes when lowercased. Example: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability for the compiler to track if a string contains uppercase or lowercase characters, and tries to reduce conversions between uppercase and lowercase strings.
I haven't found any real-world benchmark speedups from this yet, but it does make the compiler produce cleaner code.