Add user filter to license logging and extend DEVLicenseLogCleanup to cover DEVLicenseTablesUsers#14
Open
Add user filter to license logging and extend DEVLicenseLogCleanup to cover DEVLicenseTablesUsers#14
Conversation
Co-authored-by: TrudAX <26786918+TrudAX@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve data modification logging for license usage log utility
License usage log: add form-level data modification logging
Mar 13, 2026
…SecurableType fields Co-authored-by: TrudAX <26786918+TrudAX@users.noreply.github.com>
Copilot
AI
changed the title
License usage log: add form-level data modification logging
License usage log: real-time write operation logging via form datasource events
Mar 13, 2026
…; use DEVLicenseTablesUsers in DEVLicenseReportCalc Co-authored-by: TrudAX <26786918+TrudAX@users.noreply.github.com>
Copilot
AI
changed the title
License usage log: real-time write operation logging via form datasource events
Consolidate real-time write logging into DEVLicenseElementUsageLogMonitor; include DEVLicenseTablesUsers in report calc
Mar 13, 2026
There was a problem hiding this comment.
Pull request overview
This PR consolidates real-time write-event logging by absorbing DEVLicenseWriteMonitor and DEVLicenseWriteLogHandler into DEVLicenseElementUsageLogMonitor, and adds DEVLicenseTablesUsers real-time write data to the license report calculation.
Changes:
- Moved write-event subscriber, datasource handlers (
onDsInserted/onDsUpdated/onDsDeleted), andlogWriteintoDEVLicenseElementUsageLogMonitorwith a newusedWriteSetstatic field for session-level deduplication - Added a new
DEVLicenseCaptureWriteLogparameter field toSysIntParametersand newAOTName/SecurableTypefields toDEVLicenseTablesUsers - Added a second population pass in
DEVLicenseReportCalc.processLicenseElementUsageLogLineto includeDEVLicenseTablesUsersrows withRealTime*sources in license entitlement resolution
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
DEVLicenseElementUsageLogMonitor.xml |
Absorbs write-event logic: new usedWriteSet field, form subscriber, DS event handlers, and logWrite method |
DEVLicenseReportCalc.xml |
Adds query over DEVLicenseTablesUsers for RealTime* sources to feed license report user lines |
DEVLicenseTablesUsers.xml |
Adds AOTName and SecurableType fields and field group entries |
SysIntParameters.DEVLicenseUtils.xml |
Adds DEVLicenseCaptureWriteLog parameter field |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+299
to
+303
| str usageKey = strFmt('%1|%2|%3|%4', | ||
| tablesUsers.UserId, | ||
| tablesUsers.TableName, | ||
| tablesUsers.Source, | ||
| tablesUsers.AOTName); |
…leanup in DEVLicenseLogCleanup Co-authored-by: TrudAX <26786918+TrudAX@users.noreply.github.com>
Copilot
AI
changed the title
Consolidate real-time write logging into DEVLicenseElementUsageLogMonitor; include DEVLicenseTablesUsers in report calc
Add user filter to license logging and extend DEVLicenseLogCleanup to cover DEVLicenseTablesUsers
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two enhancements to the DEVLicense usage logging infrastructure.
User filter parameter (
SysIntParameters.DEVLicenseUtils)New
DEVLicenseUserFilterfield (NotesLine) onSysIntParameters. When populated, only users whose ID is a substring of this value are logged — empty means log everyone.Filter is enforced in both logging paths:
DEVLicenseElementUsageLogMonitor.insertLogRecord(element usage log)DEVLicenseElementUsageLogMonitor.logWrite(write operations /DEVLicenseTablesUsers)DEVLicenseTablesUsers cleanup (
DEVLicenseLogCleanup)DEVLicenseLogCleanup.runnow handlesDEVLicenseTablesUsersalongside the existingDEVLicenseElementUsageLog:keepDaysbyCreatedDateTime(UserId, TableName, Source, AOTName), retaining only the latestRecIdper group💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.