Skip to content
This repository was archived by the owner on Jun 24, 2025. It is now read-only.

Slash commands#2336

Merged
eliandoran merged 20 commits intodevelopfrom
feature/ckeditor_premium_slash_commands
Jun 17, 2025
Merged

Slash commands#2336
eliandoran merged 20 commits intodevelopfrom
feature/ckeditor_premium_slash_commands

Conversation

@eliandoran
Copy link
Copy Markdown
Contributor

No description provided.

@SiriusXT
Copy link
Copy Markdown
Member

This is a very convenient feature.
Just curious - will this functionality continue to be provided? What's the deal when the key expires?

@eliandoran
Copy link
Copy Markdown
Contributor Author

Just curious - will this functionality continue to be provided? What's the deal when the key expires?

@SiriusXT , yup, we got an open-source deal with them to get some premium features. When the key expires we just need to renew it.

If you keep a version for more than 3 months without update, I'll need to make it fall back to not using premium features.

Not sure why the expiration date is only 3 months but it is what it is.

@capi
Copy link
Copy Markdown

capi commented Jun 17, 2025

While I do understand the wish for this feature (I have it myself), is it really in the best interest of the project to build on something that requires the good-will of a company to renew their key and forces continuous updates just not to degrade? Once the flood door is broken, it feels more and more functionality might be built on such premium features and suddenly falling back to "just disable it once the license runs out" is not so feasible any more?

@eliandoran
Copy link
Copy Markdown
Contributor Author

@capi , I understand the concern.

Although I have my concerns regarding the expiration of the license, we have to understand that those are add-on features.

is it really in the best interest of the project to build on something that requires the good-will of a company to renew their key and forces continuous updates just not to degrade?

Indeed, that would be problematic if some core features were part of this premium scheme. In our case, it's only a few (we didn't get full premium but only a subset of them known as the productivity pack) and it's not going to increase.

Regardless, we would be doing continuous updates for dependencies, so it's only a slight hiccup in terms of maintenance. Users should also periodically update, regardless of whether they want premium features or not. I'll try to see if the expiration date of these license keys can be extended.

Once the flood door is broken, it feels more and more functionality might be built on such premium features and suddenly falling back to "just disable it once the license runs out" is not so feasible any more?

We don't actually build on top of premium features, we just enable them. In our case, it's going to be slash commands and templates/snippets.

@capi
Copy link
Copy Markdown

capi commented Jun 17, 2025

@eliandoran Thanks for taking the time to address my feedback. I'm actually looking forward to the feature, so fingers crossed everything works out in the long-term :-)

@eliandoran eliandoran marked this pull request as ready for review June 17, 2025 09:49
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 17, 2025
@eliandoran eliandoran merged commit 3b579a3 into develop Jun 17, 2025
9 of 10 checks passed
@eliandoran eliandoran deleted the feature/ckeditor_premium_slash_commands branch June 17, 2025 09:49
@eliandoran eliandoran added this to the v0.96.0 milestone Jun 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants