This repository was archived by the owner on Jun 24, 2025. It is now read-only.
flake: fix Electron version, fix Wayland support, fix source filter#2329
Merged
eliandoran merged 5 commits intoTriliumNext:developfrom Jun 17, 2025
Merged
flake: fix Electron version, fix Wayland support, fix source filter#2329eliandoran merged 5 commits intoTriliumNext:developfrom
eliandoran merged 5 commits intoTriliumNext:developfrom
Conversation
Also fix the source filtering logic to work properly.
dosubot
bot
added
the
size:S
Member
Author
|
Odd CI failure. Perhaps I should make future PRs from a branch on this repository.. Anyway, I think it should be possible to fix the icon (right now it shows the default X / Wayland icon). Testing it now. |
The previous value points to a file that no longer exists in the release builds. This file also only exists in the flake build.
FliegendeWurst
commented
Jun 16, 2025
|
|
||
| function getIcon() { | ||
| return path.join(RESOURCE_DIR, "images/app-icons/png/256x256" + (isDev ? "-dev" : "") + ".png"); | ||
| return path.join(RESOURCE_DIR, "../public/assets/icon.png"); |
Member
Author
There was a problem hiding this comment.
^ The previous path doesn't exist in the (current) release build.
The new path does exist in the flake build (and the release app.asar), but it doesn't seem to load, unfortunately..
eliandoran
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.