Skip to content

ci: disable fail-fast in test matrix#389

Merged
TomerFi merged 2 commits intomasterfrom
ci/disable-fail-fast
Feb 27, 2026
Merged

ci: disable fail-fast in test matrix#389
TomerFi merged 2 commits intomasterfrom
ci/disable-fail-fast

Conversation

@TomerFi
Copy link
Copy Markdown
Owner

@TomerFi TomerFi commented Feb 27, 2026

Summary

  • Adds fail-fast: false to the test matrix strategy so individual Node version failures don't cancel the remaining jobs
  • Addresses the Node 25 ESM compat issue breaking node: latest without hiding Node 20 results

Context

PR #388 (c8 10→11) fails on node: latest (v25.7.0) due to a yargs CJS/ESM interop issue. With fail-fast (default: true), the Node 25 failure cancels the Node 20 jobs before they complete.

Summary by CodeRabbit

  • Chores
    • Test pipeline updated to run all node version combinations (now includes additional Node.js versions) and configured to continue executing remaining jobs when failures occur for more comprehensive results.
    • Minor cleanup: removed an unnecessary trailing blank line in the CI workflow.

Prevents a single Node version failure (e.g. Node 25 ESM compat
issue) from cancelling the remaining matrix jobs.

Signed-off-by: Tomer Figenblat <tomer.figenblat@gmail.com>
Signed-off-by: Tomer Figenblat <tomer@figenblat.com>
@auto-me-bot auto-me-bot bot added the status: needs review Pull request needs a review label Feb 27, 2026
@snyk-io
Copy link
Copy Markdown

snyk-io bot commented Feb 27, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4286b0d and 1848ef5.

📒 Files selected for processing (1)
  • .github/workflows/test_package.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/test_package.yml

📝 Walkthrough

Walkthrough

Updates to the GitHub Actions test workflow: adds fail-fast: false to the matrix strategy, expands the node matrix from ['20','latest'] to ['20','22','24'], and removes a trailing blank line in the workflow file.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Configuration
​.github/workflows/test_package.yml
Added fail-fast: false to the test job matrix strategy; expanded matrix.node from ['20','latest'] to ['20','22','24']; removed trailing blank line.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

Matrix branches line up, no one sent away,
Every node gets its turn to run and play,
Fail-fast silenced, let each job sing—
More data, more green, fewer early swings. 🎭✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'ci: disable fail-fast in test matrix' accurately captures the main change—disabling fail-fast in the GitHub Actions test job strategy.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ci/disable-fail-fast

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.97%. Comparing base (3ce2aa4) to head (1848ef5).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #389   +/-   ##
=======================================
  Coverage   46.97%   46.97%           
=======================================
  Files           3        3           
  Lines         149      149           
=======================================
  Hits           70       70           
  Misses         79       79           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Replace 'latest' with explicit versions to avoid breakage from
non-LTS Node releases (e.g. Node 25 breaking yargs CJS/ESM interop).

Signed-off-by: Tomer Figenblat <tomer@figenblat.com>
@TomerFi TomerFi merged commit 4dcfbac into master Feb 27, 2026
17 checks passed
@TomerFi TomerFi deleted the ci/disable-fail-fast branch February 27, 2026 23:36
@auto-me-bot auto-me-bot bot added status: merged Pull request merged and removed status: needs review Pull request needs a review labels Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: merged Pull request merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant