Conversation
firasrg
commented
Mar 2, 2026
application/src/main/java/org/togetherjava/tjbot/features/system/BotCore.java
Show resolved
Hide resolved
firasrg
commented
Mar 2, 2026
application/src/main/java/org/togetherjava/tjbot/features/system/BotCore.java
Show resolved
Hide resolved
Zabuzard
requested changes
Mar 3, 2026
| private static final ExecutorService COMMAND_SERVICE = Executors.newCachedThreadPool(); | ||
| private static final ScheduledExecutorService ROUTINE_SERVICE = | ||
| Executors.newScheduledThreadPool(5); | ||
| private final Config config; |
Contributor
Author
There was a problem hiding this comment.
it's not being used ?
| * @param config the configuration to use for this system | ||
| */ | ||
| public BotCore(JDA jda, Database database, Config config) { | ||
| this.config = config; |
Comment on lines
+102
to
+103
| // Initialize analytics service | ||
| analyticsService = new AnalyticsService(database); |
Member
There was a problem hiding this comment.
BotCore shouldnt own AnalyticsService. especially bc its also needed in Features.
Create it in the class one above both and then distribute it there properly. I.e. create it in Application.java next to the Config and then give it to BotCore through constructor and also to Features the same way as Config is passed around
| * Commands should call {@link #recordCommandExecution(long, String, long, boolean, String)} after | ||
| * execution to track their usage. | ||
| */ | ||
| public final class AnalyticsService { |
| import java.time.Instant; | ||
|
|
||
| /** | ||
| * Service for tracking and recording command usage analytics. |
Member
There was a problem hiding this comment.
its not only command usage but general analytics. so Service for tracking and recording events for analytics purposes
| this.config = config; | ||
| Collection<Feature> features = Features.createFeatures(jda, database, config); | ||
|
|
||
| // Initialize analytics service |
Comment on lines
+386
to
+401
| try { | ||
| requireUserInteractor(UserInteractionType.SLASH_COMMAND.getPrefixedName(name), | ||
| SlashCommand.class) | ||
| .onSlashCommand(event)); | ||
| .onSlashCommand(event); | ||
|
|
||
|
|
||
| analyticsService.recordCommandSuccess(event.getChannel().getIdLong(), name, | ||
| event.getUser().getIdLong()); | ||
| } catch (Exception ex) { | ||
|
|
||
| analyticsService.recordCommandFailure(event.getChannel().getIdLong(), name, | ||
| event.getUser().getIdLong(), | ||
| ex.getMessage() != null ? ex.getMessage() : ex.getClass().getSimpleName()); | ||
|
|
||
| throw ex; | ||
| } |
Member
There was a problem hiding this comment.
- remove that try-catch stuff.
- log before the slash command is called, not after, i.e. write sth like:
COMMAND_SERVICE.execute(() -> {
UserInteractor interactor = requireUserInteractor(...);
metrics.count("slash-" + name);
interactor.onSlashCommand(event);
});| @@ -0,0 +1,13 @@ | |||
| CREATE TABLE command_usage | |||
Member
There was a problem hiding this comment.
rename table to metrics or metric_events
Comment on lines
+3
to
+9
| id INTEGER PRIMARY KEY AUTOINCREMENT, | ||
| channel_id BIGINT NOT NULL, | ||
| command_name TEXT NOT NULL, | ||
| user_id BIGINT NOT NULL, | ||
| executed_at TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP, | ||
| success BOOLEAN NOT NULL DEFAULT TRUE, | ||
| error_message TEXT |
Member
There was a problem hiding this comment.
remove, all we want is:
id INTEGER NOT NULL PRIMARY KEY AUTOINCREMENT,
event TEXT NOT NULL,
happened_at TIMESTAMP NOT NULL
Comment on lines
+12
to
+13
| CREATE INDEX idx_command_usage_channel ON command_usage(channel_id); | ||
| CREATE INDEX idx_command_usage_command_name ON command_usage(command_name); |
firasrg
force-pushed
the
firasrg/analytics
branch
from
f56996b to
25a4407
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Early implementation of basic analytics for TJ Bot
What’s done so far:
AnalyticsServicefor analytics Logic and persistence in Database (V16 DB Migration included);/pingslash command use savedUPDATE 06/03/2025
Following @Zabuzard CR, the analytics feature is no more specified for slash commands. Now, it's open to track any other sort of events!
Demo: the new table structure
