Added "Mark Active" button to help-thread "inactivity-closed" message#1423
Merged
Zabuzard merged 9 commits intoTogether-Java:developfrom Mar 3, 2026
Merged
Added "Mark Active" button to help-thread "inactivity-closed" message#1423Zabuzard merged 9 commits intoTogether-Java:developfrom
Zabuzard merged 9 commits intoTogether-Java:developfrom
Conversation
|
|
Zabuzard
requested changes
Mar 2, 2026
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadAutoArchiver.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadAutoArchiver.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCreatedListener.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCreatedListener.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCreatedListener.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadAutoArchiver.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadAutoArchiver.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCreatedListener.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCreatedListener.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCreatedListener.java
Outdated
Show resolved
Hide resolved
Zabuzard
requested changes
Mar 2, 2026
Member
Zabuzard
left a comment
Zabuzard
left a comment
There was a problem hiding this comment.
looks much better now. the component id generator topic needs to be looked into. ill dig a bit to assist better on it and then callback
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadAutoArchiver.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCreatedListener.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCreatedListener.java
Outdated
Show resolved
Hide resolved
Zabuzard
requested changes
Mar 2, 2026
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCreatedListener.java
Outdated
Show resolved
Hide resolved
- Make HelpThreadAutoArchiver implement UserInteractor (name: thread-inactivity) - Own ComponentIdInteractor for mark-active button ID generation - Move onButtonClick/onInactivityButton from listener to archiver - Remove mark-active routing and getComponentIdInteractor from listener - Remove unused generateMarkActiveId from HelpSystemHelper - Extract mark-active literal to constant (SonarLint S1192)
Zabuzard
requested changes
Mar 2, 2026
Member
Zabuzard
left a comment
Zabuzard
left a comment
There was a problem hiding this comment.
the direction is great now. just some smaller cleanup 👍
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadAutoArchiver.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadAutoArchiver.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadAutoArchiver.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadAutoArchiver.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/Features.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Refactored with the cleanups, looks good to me now 👍🏻 |
Zabuzard
changed the title
christolis
requested changes
Mar 2, 2026
application/src/main/java/org/togetherjava/tjbot/features/Features.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadAutoArchiver.java
Show resolved
Hide resolved
Zabuzard
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1140
Overview
Added a "Mark Active" button to help threads flagged for inactivity.
Instead of a "Dismiss" button, I put "Mark Active" because it better reflects the user's intent to keep the thread open. When clicked, the bot unarchives the thread and deletes the inactivity warning to keep the history clean.
Changes
onButtonClickusing a newthread-inactivitynamespace.handleMarkActiveInteractionto unarchive the thread and delete the bot's warning message.Why this approach?
A button is more reliable than a message listener since it bypasses the 14-day deletion limit and doesn't require extra database tracking. It's a simple fix that doesn't mess with the existing thread logic.