fix: crash when using timeline <kind> import CLI command#415
Open
FelipeDefensor wants to merge 1 commit intodevfrom
Open
fix: crash when using timeline <kind> import CLI command#415FelipeDefensor wants to merge 1 commit intodevfrom
timeline <kind> import CLI command#415FelipeDefensor wants to merge 1 commit intodevfrom
Conversation
The import logic was wrong, but tests didn't fail because the modules where already imported earlier in the session.
Collaborator
Author
|
I don't know how we could test this automatically. @azfoo, could you reproduce and test the fix manually before approving? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The import logic was wrong, but tests didn't fail because the modules where already imported earlier in the session.