Merged
Conversation
FelipeDefensor
requested changes
Mar 18, 2026
Collaborator
FelipeDefensor
left a comment
FelipeDefensor
left a comment
There was a problem hiding this comment.
This is a clear improvement over my implementation. The only thing, apart from the comments, is that I am not sure we want to silently "adjust" conflicting IDs in the long term. A user might, for instance, write a script that creates a components with a hardcoded ID, and later use that ID to get the component for a future operation. That operation would misteriously fail if we changed the ID when creating the component without an error or warning. Since we are rather far from such an API in the moment, I am fine with going for what you propose, at least for now.
also removes scanning through all of the current ids if no id is given.
FelipeDefensor
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also removes scanning through all of the current ids if no id is given.