chore(rust generation): bump tonic and prost to 0.14#68
Merged
rustybee42 merged 1 commit intomainfrom Mar 13, 2026
Merged
Conversation
iamjoemccormick
requested changes
Mar 11, 2026
Member
iamjoemccormick
left a comment
iamjoemccormick
left a comment
There was a problem hiding this comment.
Merging the changes to protoc-rs are the only really blocker. My one question may not be worth pursuing further (or not possible to pursue without changes to external dependencies).
iamjoemccormick
approved these changes
Mar 12, 2026
Member
iamjoemccormick
left a comment
iamjoemccormick
left a comment
There was a problem hiding this comment.
LGTM from a code review perspective. We just need to rerun checks after merging the protoc-rs changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on generating with updated
protoc-rs, see ThinkParQ/protoc-rs#4