WL-0MN0SS4UD0SJAC3T: lock non-stacking of in-progress & ancestor boosts in computeScore#978
Merged
SorraTheOrc merged 1 commit intomainfrom Mar 22, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent stacking of in-progress and ancestor boosts in computeScore(). The scoring code now applies a single multiplier (in-progress OR ancestor) exactly once. Added a focused unit test to lock this invariant.
Changes
Testing
npx vitest -t "computeScore non-stacking invariant"npx vitest -t "in-progress boost in computeScore / reSort > should apply only the in-progress boost (not ancestor boost) when item is itself in-progress"Notes
Request
Please review the change and verify CI. If you want, I can also add a small unit test asserting the numeric multiplier directly (extracting computeScore) or regenerate build artifacts if needed.