Open
Conversation
This was referenced Nov 2, 2025
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Markets support to Shopkeeper buckets and updates ignore rules so required fixtures are tracked. Improves docs and tests accordingly.
What’s Changed
.gitignore
.shopkeeperglobally, but unignoresrc/utilities/fixtures/.shopkeeper/so repo fixtures are tracked.README / Docs
config/markets.jsonin the example tree.Patterns & Flags
getSettingsPatterns()now returns:['config/settings_data.json', 'config/markets.json', 'templates/**/*.json', 'sections/*.json']CLI_SETTINGS_FLAGSincludesconfig/markets.jsonso--onlyflags cover markets.getSettingsFolders()left unchanged (no locales added here).Bucket Scaffolding
config/markets.jsonwhere applicable (no locales folder created in this PR).Tests
config/markets.jsonin pulls/flags.Fixtures
src/utilities/fixtures/.shopkeeper/production/config/markets.jsonsrc/utilities/fixtures/theme/config/markets.jsonWhy
.shopkeeperfixtures tracked for tests/docs, while still ignoring other.shopkeeperpaths.Behavior / Compatibility
config/markets.jsonif present).Testing
vitest --run).file:install that--onlyflags includeconfig/markets.json.Split from #177