Use program name logic from former InitRunFiles#10095
Use program name logic from former InitRunFiles#10095hzeller wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
|
FYI @dsengupta0628 as you were working on the program name part. |
|
clang-tidy review says "All clean, LGTM! 👍" |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the legacy runfiles shim and InitRunFiles.cpp, centralizing the logic for determining the executable's location into a new GetProgramLocation function within bazel/tcl_library_init.cc. The review identified several critical issues in the new function, including potential compilation errors, buffer over-reads on Linux, and undefined behavior on macOS. A suggested implementation was provided to address these bugs and restore path length validation.
hzeller
force-pushed
the
feature-20260409-runfile
branch
from
ec41ae9 to
302fba9
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
hzeller
force-pushed
the
feature-20260409-runfile
branch
from
302fba9 to
f7525a1
Compare
Also, remove now the old, not used anymore InitRunFiles and library. Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
force-pushed
the
feature-20260409-runfile
branch
from
f7525a1 to
46344b5
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
1 participant
Also, remove now the old, not used anymore InitRunFiles and library.