Skip to content

fix(integrations): Add validation for external project and default issue type before saving settings#169

Merged
therealbrad merged 2 commits intomainfrom
bug/166
Mar 31, 2026
Merged

fix(integrations): Add validation for external project and default issue type before saving settings#169
therealbrad merged 2 commits intomainfrom
bug/166

Conversation

@therealbrad
Copy link
Copy Markdown
Contributor

Description

  • Implemented a canSave memoized function to determine if the save button should be enabled based on the selected integration provider and required fields.
  • Updated UI to display error messages when required fields are not filled, enhancing user feedback.
  • Modified the loading state handling in the Create Issue form for better user experience.

Related Issue

Closes #166

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement

How Has This Been Tested?

Describe the tests you ran to verify your changes:

  • Unit tests
  • Integration tests
  • E2E tests
  • Manual testing

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have signed the CLA

…sue type before saving settings

- Implemented a `canSave` memoized function to determine if the save button should be enabled based on the selected integration provider and required fields.
- Updated UI to display error messages when required fields are not filled, enhancing user feedback.
- Modified the loading state handling in the Create Issue form for better user experience.
…on is not clickable until those fields are set.
@therealbrad therealbrad merged commit 66b9e6a into main Mar 31, 2026
5 checks passed
@therealbrad therealbrad deleted the bug/166 branch March 31, 2026 19:24
@therealbrad
Copy link
Copy Markdown
Contributor Author

🎉 This PR is included in version 0.19.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] When a Project's Jira integration is not connected to a specific Jira project, create Jira issue shows continuous loading

1 participant