feat(config-qemu-memory-string): parse memory capacity both from string and integer.#413
Conversation
…ng and integer representations.
1bb5386 to
58f7740
Compare
|
@Andrew-Bezzubtsev the structs with json tags aren't directly used to take the PVE api response. proxmox-api-go/proxmox/config_qemu_memory.go Lines 64 to 68 in 2dd4b9b |
|
@Tinyblargon oh, ok! Thanks for your response. These changes actually come from my custom-made patch for |
|
@Andrew-Bezzubtsev The reason we have abandoned the 2.9 released is because so many parts make wrong assumptions about the data structures of PVE. So many things would behave wierdly or just panic the moment you went slightly outside the exact use case the developer intended. The main panic of 2.9 has been fixed, but this project has had 60000 lines changed since the 2.9 realease. Most of these changes were to address panics in PCI, Network, Disk, Cloud-init, and many more places. For the permission issue we have a rudimentary framework that can help with troubleshooting, but it was never used due to some oversight in its design and changing priorities. |
As for 8.4.1 (maybe earlier),
GET /api2/json/nodes/{node}/qemu/{vmid}/configgives string value for"memory"field. This PR secures correct handling of both numeric and literal values.For reference, see Proxmox VE API reference.