Draft
Conversation
Collaborator
Author
|
To keep compatibility with the Terraform provider all settings in
Might as well make The new schema would look like this: type GuestHA struct {
Comment *string `json:"comment"` // Description.
Delete bool `json:"remove,omitempty"` // When true, remove HA settings for the Guest.
Group *HaGroupName `json:"group"` // May be empty, in which case the guest is not part of a group.
Reallocates *HaRelocate `json:"reallocates"`
Restarts *HaRestart `json:"restarts"`
State *HaState `json:"state"`
} |
mleone87
approved these changes
Mar 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for all guest HA options.
These HA settings have been added as an optional substructure to
ConfigQemuandConfigLxc, not setting this means that the HA settings won't be updated.The following type changes where made:
Before:
After:
Marked the following as deprecated
*Client.ReadVMHA()*Client.UpdateVMHA()Will make a corresponding pr to the Terraform provider as well.
Closes #314