Fix responssive layout and enable mobile layout#1751
Open
Hemsby wants to merge 3 commits intoTechnitiumSoftware:masterfrom
Open
Fix responssive layout and enable mobile layout#1751Hemsby wants to merge 3 commits intoTechnitiumSoftware:masterfrom
Hemsby wants to merge 3 commits intoTechnitiumSoftware:masterfrom
Conversation
Member
|
Thanks for the PR. I really appreciate the efforts went in to it. I tested the PR for both desktop and mobile and the UI still requires a lot of work to make it usable on both desktop and mobile. It would be a big task to make all the changes to so that the interface looks polished for both views. I also prefer the current UI on mobile just because it give a consistent view. It does require a bit of zooming or using the landscape view but it then works in a very expected way without any other UI issues. This also makes maintenance easy since making new changes does not require testing it for various other mobile views. Thus it would be really difficult to accommodate this PR at this point. Thanks once again for the efforts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also should fix #1629