fix: Color data is properly loaded#42
Merged
mysticdrew merged 1 commit intoTeamJM:masterfrom May 11, 2025
grimly:patch-2
Merged
fix: Color data is properly loaded#42mysticdrew merged 1 commit intoTeamJM:masterfrom grimly:patch-2
mysticdrew merged 1 commit intoTeamJM:masterfrom
grimly:patch-2
Conversation
Original issue raised from usage in GTNH modpack. The data format generated in `colorPalette.json` is different from what is expected by this file script. The data still available and just required some refactor. Instead of `colorPalette.table`, a refactor of `colorPalette.basicColors` can be used. This refactor runs only when needed (just in case the previous format is in use somehow).
|
|
Member
|
5.2.9 should be available on the download sites shortly. ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original issue raised from usage in GTNH modpack.
The data format generated in
colorPalette.jsonis different from what is expected by this file script. The data still available and just required some refactor. Instead ofcolorPalette.table, a refactor ofcolorPalette.basicColorscan be used. This refactor runs only when needed (just in case the previous format is in use somehow).