Skip to content

[WIP] Feat: summary retry api (#436)#440

Open
Bangdayeon wants to merge 1 commit intomainfrom
feat/#436-summary-retry-api
Open

[WIP] Feat: summary retry api (#436)#440
Bangdayeon wants to merge 1 commit intomainfrom
feat/#436-summary-retry-api

Conversation

@Bangdayeon
Copy link
Copy Markdown
Member

관련 이슈

PR 설명

  • 백엔드 api 개발 완료 후 진행

@Bangdayeon Bangdayeon self-assigned this Mar 22, 2026
@Bangdayeon Bangdayeon added the wontfix This will not be worked on label Mar 22, 2026
@Bangdayeon Bangdayeon linked an issue Mar 22, 2026 that may be closed by this pull request
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 22, 2026

Walkthrough

LinkCardDetailPanel 컴포넌트에서 onRetrySummary 콜백 prop이 제거되었습니다. 이에 따라 SummarySection으로 전달되던 onRetrySummary prop도 더 이상 전달되지 않습니다. 대신 SummarySection 내부에 onRetrySummary 콜백이 새로 추가되었으며, 현재는 콘솔에 'retry'를 로깅하고 "다시 시도" 버튼의 onClick 이벤트에 연결되어 있습니다. 이로써 요약 재시도 로직이 부모 컴포넌트에서 자식 컴포넌트 내부로 이동했습니다.

🚥 Pre-merge checks | ✅ 2 | ❌ 2

❌ Failed checks (2 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive PR 설명이 필수 템플릿 구조는 따르고 있으나, PR 설명 섹션이 '백엔드 api 개발 완료 후 진행'이라는 불완전한 내용만 있습니다. 변경 사항에 대한 상세한 설명을 추가하세요. 제거된 props, 추가된 내부 콜백, 그리고 현재 구현 상태를 명확히 기술하면 좋습니다.
Linked Issues check ❓ Inconclusive PR은 #436 이슈를 연결하고 있으며, 변경 사항이 summary retry 기능과 관련되어 있으나 완전한 API 연결 구현이 아닌 중간 단계로 보입니다. PR이 [WIP] 상태이고 현재 console.log만 있으므로, 백엔드 API 연결 완료 후 재평가가 필요합니다.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed 제목은 주요 변경 사항인 summary retry 기능 개발을 명확히 나타내고 있으나, [WIP] 태그와 이슈 번호가 포함되어 다소 장황합니다.
Out of Scope Changes check ✅ Passed 모든 변경 사항이 summary retry 기능 구현과 관련되어 있으며, 연결된 이슈 #436의 범위 내에 있습니다.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/#436-summary-retry-api

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use OpenGrep to find security vulnerabilities and bugs across 17+ programming languages.

OpenGrep is compatible with Semgrep configurations. Add an opengrep.yml or semgrep.yml configuration file to your project to enable OpenGrep analysis.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/components/wrappers/LinkCardDetailPanel/Sections/SummarySection.tsx`:
- Around line 36-38: The onRetrySummary handler currently only logs to console
and must call the backend retry API; replace the console.log in onRetrySummary
with a useMutation-based call (e.g., create a retrySummary mutation via
useMutation or a provided useRetrySummary hook) and invoke its mutate/trigger
method inside onRetrySummary, handling loading, success and error states (update
local state or refetch summary on success and show an error toast or set error
state on failure); ensure you reference and import the mutation hook and use the
exact handler name onRetrySummary and the mutation identifier (e.g.,
retrySummaryMutation or useRetrySummary) so the "다시 시도" button actually performs
the backend retry.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7ed45d93-8f61-4c1c-b284-d4c13e044180

📥 Commits

Reviewing files that changed from the base of the PR and between b6eff47 and 926e18d.

📒 Files selected for processing (2)
  • src/components/wrappers/LinkCardDetailPanel/LinkCardDetailPanel.tsx
  • src/components/wrappers/LinkCardDetailPanel/Sections/SummarySection.tsx
💤 Files with no reviewable changes (1)
  • src/components/wrappers/LinkCardDetailPanel/LinkCardDetailPanel.tsx

Comment on lines +36 to +38
const onRetrySummary = () => {
console.log('retry'); // TODO: 백엔드 확인 후 api 연결
};
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

재시도 버튼이 실제 재시도 동작을 수행하지 않습니다.

Line 36-37에서 console.log만 실행되어, 에러 상태의 "다시 시도" 버튼이 백엔드 재시도 API를 호출하지 않습니다. 현재 PR 목표(요약 재시도 API 연결) 기준으로 기능이 미완성입니다.

수정 예시
-  const onRetrySummary = () => {
-    console.log('retry'); // TODO: 백엔드 확인 후 api 연결
-  };
+  const onRetrySummary = () => {
+    open('RE_SUMMARY', { linkId });
+  };

원하시면 이 버튼에서 직접 재시도 API를 호출하도록 useMutation 기반 연결 코드까지 바로 제안드릴게요.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/components/wrappers/LinkCardDetailPanel/Sections/SummarySection.tsx`
around lines 36 - 38, The onRetrySummary handler currently only logs to console
and must call the backend retry API; replace the console.log in onRetrySummary
with a useMutation-based call (e.g., create a retrySummary mutation via
useMutation or a provided useRetrySummary hook) and invoke its mutate/trigger
method inside onRetrySummary, handling loading, success and error states (update
local state or refetch summary on success and show an error toast or set error
state on failure); ensure you reference and import the mutation hook and use the
exact handler name onRetrySummary and the mutation identifier (e.g.,
retrySummaryMutation or useRetrySummary) so the "다시 시도" button actually performs
the backend retry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

요약 생성 재시도 api 연결

1 participant