Open
Conversation
Jinsujin
commented
Apr 13, 2023
Comment on lines
+144
to
157
|
|
||
| case let .standbyDetail(state): | ||
| // TODO: 상세화면 띄우기 | ||
| return .none | ||
|
|
||
| case let .confirmedDetail(state): | ||
| // TODO: 상세화면 띄우기 | ||
| return .none |
Contributor
Author
There was a problem hiding this comment.
상세화면 처리에 대해
약속 관리 화면에서 처리하던 상세화면을 상위 객체-HomeContainerCore 가 처리할 수 있도록 액션을 연결했습니다.
@GangWoon 님
선택한 Promise 에 대해 상세화면을 띄우는 로직이 이미 있는데, 이를 활용해야 할까요..?
아니면 약속관리에서 띄우는 상세화면에 대한 State 를 따로 만들어서 처리해도 괜찮을까요?
private extension HomeContainerCore.State {
var selectedPromise: Promise? {
guard
let destinationState,
let state = (/HomeContainerCore.DestinationState.promiseList).extract(from: destinationState),
let promise = state.selectedPromise
else { return nil }
return promise
}
if let selectedPromise = viewStore.selectedPromise {
PromiseDetailView(state: .init(promise: selectedPromise))
.opacity(viewStore.selectedDetent == .large ? 1 : .zero)
}
Contributor
There was a problem hiding this comment.
따로 관리하셨으면 좋겠습니다.
HomeContainer에서 사용되는 PromiseDetail의 경우 조금 UX를 제공합니다.(풀 스크린 오버가 아니며, 다른 화면도 같이 노출될 수 있는 환경입니다.)
junyng
requested changes
Apr 15, 2023
Contributor
junyng
left a comment
There was a problem hiding this comment.
Adhoc 배포 방법에 대해 관심이 생기네요
빠르게 배포 적용해주셔서 감사합니다
모듈 명 관련해 코맨트 남겼습니다
수고많으셨습니다 🙇♂️
- 메인 화면에서 처리하기 위함 - 약속관리에서 상위로 전달하는 이벤트는 delegate Action 으로 정의
- 배포시 변경 필요했음
rebase 후 빌드에러 해결
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE
작업 내용
처리 못한 작업
실행 화면
Check List
[ISSUE-{N}] PR 제목으로 작성