chore: Switch delete user settings endpoint to read from query params#176
Open
morgan-wowk wants to merge 1 commit intomasterfrom
Open
chore: Switch delete user settings endpoint to read from query params#176morgan-wowk wants to merge 1 commit intomasterfrom
morgan-wowk wants to merge 1 commit intomasterfrom
Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
**Changes:** * Wrap del user settings handler in `add_parameter_annotation_metadata` to instruct FastAPI to read from the query params instead of request body
morgan-wowk
force-pushed
the
delete-user-settings-query-param
branch
from
9724068 to
e7680c6
Compare
morgan-wowk
changed the title
morgan-wowk
changed the title
Collaborator
Author
Collaborator
Author
|
This one can be closed if you prefer to keep what we got already ☝️ |
Contributor
|
Hmm. Query is not great for non-primitive parameters. For example, dictionaries are still a big problem. |
Contributor
|
How does the URL look like? Does FastAPI docs support it (schema, UI)? |
Ark-kun
approved these changes
Mar 20, 2026
Collaborator
Author
|
The URL would be
Can you clarify? Do you mean OpenAPI spec and swagger / docusaurus UI? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
add_parameter_annotation_metadatato instruct FastAPI to readsetting_namesparameter from query params