fix: Use relative time when viewing logs/events when a node is still running#1977
Open
yuechao-qin wants to merge 1 commit intomasterfrom
Open
fix: Use relative time when viewing logs/events when a node is still running#1977yuechao-qin wants to merge 1 commit intomasterfrom
yuechao-qin wants to merge 1 commit intomasterfrom
Conversation
🎩 To tophat this PR:You can add the following URL parameter to your browser to tophat this PR: |
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ce826a9 to
710d4af
Compare
710d4af to
d106cbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Closes https://github.com/Shopify/oasis-frontend/issues/526
When a node is still running, the old code would put hard code
startandendtime relative to the current time the user views the node. Issues with this is:Now, the code does:
Related Issue and Pull requests
Type of Change
Checklist
Test Instructions
nowwith some minutesVideo
Use cases:
Screen Recording 2026-03-20 at 3.28.43 PM.mov (uploaded via Graphite)