Conversation
🎩 To tophat this PR:You can add the following URL parameter to your browser to tophat this PR: |
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
camielvs
force-pushed
the
03-19-fix_multiline_text_dialog_description_overflows_when_description_has_a_long_word_or_url
branch
2 times, most recently
from
fd64990 to
160f9f7
Compare
camielvs
commented
Mar 20, 2026
camielvs
commented
Mar 20, 2026
camielvs
commented
Mar 20, 2026
Mbeaulne
reviewed
Mar 20, 2026
Mbeaulne
reviewed
Mar 20, 2026
… a long word or url
camielvs
force-pushed
the
03-19-fix_multiline_text_dialog_description_overflows_when_description_has_a_long_word_or_url
branch
from
160f9f7 to
d07f86e
Compare
camielvs
requested review from
a team and
Mbeaulne
and removed request for
Mbeaulne
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix a bug where long unbroken strings (e.g. url) in the dialog description would cause horizontal overflows of the dialog container.
Dialog description is now limited to two lines, with a "show more" button give if the user wants to expand it.
The syntax language selector was also moved out of inline and given its own space so it does not overflow.
Related Issue and Pull requests
Closes https://github.com/Shopify/oasis-frontend/issues/523
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Additional Comments