chore: rm Scheduled Execution Callback from Flow Canvas

[camielvs]

Description

I may be mistaken but I think this code can be removed as the fit-to-view looks like it's successfully being taken care of elsewhere. Needs manual testing (as I don't remember why it was originally added). Hence, I've made it a separate PR.

Follow-up:

I have been exploring the implications of this PR. The removed code is currently delaying the canvas fit-view operation until after it has loaded, but before it renders. This makes the canvas load with the view centered on the content. Removal of this code causes the fit operation to happen after rendering, resulting in an animation. See the difference below. Do we want/need this? How do we feel about it?

Before (existing behaviour)

fit-view-no-animation.mov (uploaded via Graphite)

After (new behaviour)

fit-view-animated.mov (uploaded via Graphite)

Related Issue and Pull requests

Type of Change

• Cleanup/Refactor

Checklist

• I have tested this does not break current pipelines / runs functionality
• I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

Additional Comments

[github-actions]

🎩 To tophat this PR:

You can add the following URL parameter to your browser to tophat this PR:

`?tophat_location=03-09-chore_rm_scheduled_execution_callback_from_flow_canvas/372a6a3`

---

[camielvs]

• chore: rm Scheduled Execution Callback from Flow Canvas #1916 👈 (View in Graphite)
• feat: Link to Node on Canvas #1913
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[maxy-shpfy]

I see e2e tests may become flaky because of the animation, could you take a look before merging?

[camielvs]

I think I'm going to try take a bit of time to reevaluate this PR and figure out if there a better way to deal with fitView on page load whilst still avoiding an animation and duplicated code.