Fix for LilyGO T-HMI SD card

[KenVanHoeylandt]

Summary by CodeRabbit

• New Features

  • Configurable internal pull-up support for SD/MMC interface pins
  • Selectable on-chip LDO channel for SD/MMC power management with an option to disable

• Improvements

  • Improved SD card mount diagnostics and now prints card information after a successful mount

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d7027d96-f254-43c8-8f56-5dad98272f83

📥 Commits

Reviewing files that changed from the base of the PR and between 36db476 and 1a6cc81.

📒 Files selected for processing (1)

• Platforms/platform-esp32/source/drivers/esp32_sdmmc_fs.cpp

---

📝 Walkthrough

Walkthrough

Adds a new pin mapping (pin-d3) and enables pullups in the sdmmc0 device tree node. The ESP32 SDMMC binding gains pullups (bool) and on-chip-ldo-chan (int) properties. The driver config struct adds pullups and on_chip_ldo_chan fields. The SDMMC driver now sets internal pull-up flags when requested, conditionally initializes on-chip LDO only if on_chip_ldo_chan > 0, and prints card information after a successful mount.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title "Fix for LilyGO T-HMI SD card" directly relates to the main changes: enabling SD/MMC card support for the LilyGO T-HMI device by adding pin mappings, pull-up configuration, and LDO power control.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch develop

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

You can get early access to new features in CodeRabbit.

Enable the early_access setting to enable early access features such as new models, tools, and more.

[coderabbitai]

Actionable comments posted: 2

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5b3db675-3bd0-49a3-bf99-56f9ae0109b8

📥 Commits

Reviewing files that changed from the base of the PR and between e560cc7 and 36db476.

📒 Files selected for processing (4)

• Devices/lilygo-thmi/lilygo,thmi.dts
• Platforms/platform-esp32/bindings/espressif,esp32-sdmmc.yaml
• Platforms/platform-esp32/include/tactility/drivers/esp32_sdmmc.h
• Platforms/platform-esp32/source/drivers/esp32_sdmmc_fs.cpp