Skip to content

[CLEANUP] Autoformat the code#2054

Draft
oliverklee wants to merge 1 commit intomainfrom
cleanup/autoformat
Draft

[CLEANUP] Autoformat the code#2054
oliverklee wants to merge 1 commit intomainfrom
cleanup/autoformat

Conversation

@oliverklee
Copy link
Copy Markdown
Contributor

No description provided.

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 28, 2026

Pull Request Test Coverage Report for Build 23687934213

Details

  • 1 of 21 (4.76%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.2%) to 43.987%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Classes/Upgrades/AbstractListTypeToCTypeUpdate.php 0 20 0.0%
Totals Coverage Status
Change from base Build 23687894148: -2.2%
Covered Lines: 139
Relevant Lines: 316

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@DanielSiepmann DanielSiepmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to automate this via CI?
I fear we would otherwise always result in mixed formats within the extension.

@oliverklee oliverklee force-pushed the cleanup/autoformat branch 2 times, most recently from f729ce4 to 6299256 Compare March 28, 2026 14:51
@oliverklee
Copy link
Copy Markdown
Contributor Author

Is there any way to automate this via CI?

Yes, partially - we could add additional PHP-CS-Fixer rules for the things that are not part of our current ruleset and that the PhpStorm autoformattting does.

@oliverklee oliverklee marked this pull request as draft March 30, 2026 08:40
@oliverklee oliverklee moved this from In Review to In Progress in Best Practices code sprint Mar 30, 2026
@oliverklee
Copy link
Copy Markdown
Contributor Author

Marking as draft. I'll split this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants