Skip to content

[BUGFIX] Return exitcode != 0 when runTests.sh -s composerUpdate(Min|Max) fails #1936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sbuerk wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −4
Draft

[BUGFIX] Return exitcode != 0 when runTests.sh -s composerUpdate(Min|Max) fails #1936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v6
- name: Install Composer dependencies
# @todo Linting only against ^13.4 - why not against ^12.4 ?
run: Build/Scripts/runTests.sh -p ${{ matrix.php-version }} -s composerUpdateMax -t 13.4
- name: Lint PHP
run: |
Expand All @@ -27,6 +28,8 @@ jobs:
fail-fast: false
matrix:
php-version:
# @todo 8.1 does not make sense with TYPOP3 ^13.4 hard coded in the `composer install` step above.
# Drop it or use `^12.4` above or make core version part of the matrix.
- "8.1"
- "8.2"
- "8.3"
Expand Down
13 changes: 9 additions & 4 deletions Build/Scripts/runTests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,17 +552,22 @@ case ${TEST_SUITE} in
;;
composerUpdateMax)
# `dumpautoload` removed due to error with missing `composer.lock` file on publishing public assets.
COMMAND="composer config --unset platform.php; composer require --no-ansi --no-interaction --no-progress --no-install typo3/cms-core:"^${CORE_VERSION}"; composer update --no-progress --no-interaction; composer show"
${CONTAINER_BIN} run ${CONTAINER_COMMON_PARAMS} --name composer-install-max-${SUFFIX} -e COMPOSER_CACHE_DIR=.cache/composer -e COMPOSER_ROOT_VERSION=${COMPOSER_ROOT_VERSION} ${IMAGE_PHP} /bin/sh -c "${COMMAND}"
# @todo Consider to use `typo3/minimal` to enforce core version and have `typo3/cms-core`
# with `^12.4 || ^13.4` in `composer.json`.
COMMAND="(composer config --unset platform.php && composer require --no-ansi --no-interaction --no-progress --no-install 'typo3/cms-core':'^${CORE_VERSION}' && composer update --no-progress --no-interaction && composer show)"
${CONTAINER_BIN} run ${CONTAINER_COMMON_PARAMS} --name composer-install-max-${SUFFIX} -e COMPOSER_CACHE_DIR=.cache/composer -e COMPOSER_ROOT_VERSION=${COMPOSER_ROOT_VERSION} ${IMAGE_PHP} /bin/sh -c "${COMMAND[@]}"
SUITE_EXIT_CODE=$?
;;
composerUpdateMin)
# `dumpautoload` removed due to error with missing `composer.lock` file on publishing public assets.
COMMAND="composer config platform.php ${PHP_VERSION}.0; composer require --no-ansi --no-interaction --no-progress --no-install typo3/cms-core:"^${CORE_VERSION}"; composer update --prefer-lowest --no-progress --no-interaction; composer show"
${CONTAINER_BIN} run ${CONTAINER_COMMON_PARAMS} --name composer-install-min-${SUFFIX} -e COMPOSER_CACHE_DIR=.cache/composer -e COMPOSER_ROOT_VERSION=${COMPOSER_ROOT_VERSION} ${IMAGE_PHP} /bin/sh -c "${COMMAND}"
# @todo Consider to use `typo3/minimal` to enforce core version and have `typo3/cms-core`
# with `^12.4 || ^13.4` in `composer.json`.
COMMAND="(composer config platform.php ${PHP_VERSION}.0 && composer require --no-ansi --no-interaction --no-progress --no-install 'typo3/cms-core':'^${CORE_VERSION}' && composer update --prefer-lowest --no-progress --no-interaction && composer show)"
${CONTAINER_BIN} run ${CONTAINER_COMMON_PARAMS} --name composer-install-min-${SUFFIX} -e COMPOSER_CACHE_DIR=.cache/composer -e COMPOSER_ROOT_VERSION=${COMPOSER_ROOT_VERSION} ${IMAGE_PHP} /bin/sh -c "${COMMAND[@]}"
SUITE_EXIT_CODE=$?
;;
composerNormalize)
# @todo This does not make sense and is always reset within the IF-ELSE-FI block directly after this assignment.
COMMAND="composer check:composer:normalize"
if [ "${CGLCHECK_DRY_RUN}" -eq 1 ]; then
COMMAND="composer check:composer:normalize"
Expand Down
Loading